Skip to content

Dockerfile: Switch to 84codes crystal compiler container image#5473

Open
Fijxu wants to merge 1 commit intomasterfrom
fijxu/84codes-builder
Open

Dockerfile: Switch to 84codes crystal compiler container image#5473
Fijxu wants to merge 1 commit intomasterfrom
fijxu/84codes-builder

Conversation

@Fijxu
Copy link
Member

@Fijxu Fijxu commented Sep 14, 2025

Closes #5456

The 84codes Crystal container image builds libgc (bdwgc) with --enable-large-config: https://github.com/84codes/crystal-packages/blob/b321bb4358b0140a63573d9d05ccf2f06c5ae040/alpine/Dockerfile#L13-L22

I tested it locally and I'm now going to test it on my fork of Invidious https://git.nadeko.net/Fijxu/invidious/commit/b38791e7ca6b7549e3a894f26f43cb77660c798e

@Fijxu Fijxu requested a review from syeopite September 14, 2025 02:38
@Fijxu Fijxu requested a review from unixfox as a code owner September 14, 2025 02:38
@Fijxu Fijxu added the docker Pull requests that update docker code label Sep 14, 2025
@unixfox
Copy link
Member

unixfox commented Sep 14, 2025

Ah so this image fixes the memory leak?

@Fijxu
Copy link
Member Author

Fijxu commented Sep 14, 2025 •
edited
Loading

Ah so this image fixes the memory leak?

No, this is unrelated to the memory leak. It just improves GC performance and for now, my Invidious processes seem to use less memory.

2fd67c34-000f-40ed-9d5b-04f1def58b93

At 00:00 is when I changed my instance to the 84codes container image to build Invidious.

@Fijxu
Copy link
Member Author

Fijxu commented Sep 15, 2025 •
edited
Loading

After approximately 1 day and 12 hours I can confirm that the 84codes container image which uses --enable-large-config for bdwgc has a more stable memory usage when combining it with #5441. There is no memory limits (mem_limit) on my docker-compose file and I have around 8GB of memory free that Invidious could use, but the memory usage is stable ;):

image

@unixfox
Copy link
Member

unixfox commented Dec 18, 2025

#5441 got merged instead of this one.

@unixfox unixfox closed this Dec 18, 2025
@Fijxu
Copy link
Member Author

Fijxu commented Dec 18, 2025

#5441 is for memory leak

This one is for bdwgc compiled with --enable-large-config and not related to the memory leak. Is for better memory management in the GC

@unixfox unixfox reopened this Dec 18, 2025
@unixfox
Copy link
Member

unixfox commented Dec 18, 2025

@Fijxu ok. I saw that they provide ARM64: https://hub.docker.com/r/84codes/crystal/tags. Could we unify our Dockerfile for both x86 and ARM64?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@syeopite syeopite Awaiting requested review from syeopite

@unixfox unixfox Awaiting requested review from unixfox unixfox is a code owner

Assignees

No one assigned

Labels

docker Pull requests that update docker code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement] Recompile Crystal's garbage collector (bdwgc) with --enable-large-config

2 participants

@Fijxu @unixfox